[MBL-820] Update Privacy viewmodel to RX2

[mtgriego]

📲 What

Updating Privacy Viewmodel to RX2

🤔 Why

Need to get rid of RX1

📋 QA

Go to the privacy activity and confirm everything works as expected

Story 📖

MBL-820

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (36b994c) to head (cec08f8).

Files with missing lines	Patch %	Lines
...ava/com/kickstarter/viewmodels/PrivacyViewModel.kt	73.33%	5 Missing and 11 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2119      +/-   ##
============================================
- Coverage     67.64%   67.61%   -0.03%     
- Complexity     2193     2194       +1     
============================================
  Files           367      367              
  Lines         22579    22597      +18     
  Branches       3240     3248       +8     
============================================
+ Hits          15273    15279       +6     
- Misses         5569     5574       +5     
- Partials       1737     1744       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leighdouglas]

wouldnt this cause a crash if it / currentUser is null?

[mtgriego]

no, since the operation happens in order it.isNotNull checks it first, then if it is null the filter fails since its an 'and' check, if it is not null, the second check happens to cover the getValue value

fun T?.isNotNull(): Boolean {
return this != null
}

[leighdouglas]

Ah, what i mean is that im concerned with the first null check. to me, this is implying that the item could be null before hitting that first check, and my understanding is that any null value that's passed down the pipeline is an issue with rxjava 2

[mtgriego]

I believe the concept is called short circuiting. Basically since its an && it will evaluate the operations in order and if any fail along the way it doesnt continue and just marks the result as false

[leighdouglas]

got it! thank you for explaining 👍🏽

[mtgriego]

Ah, what i mean is that im concerned with the first null check. to me, this is implying that the item could be null before hitting that first check, and my understanding is that any null value that's passed down the pipeline is an issue with rxjava 2

I believe RX2 doesnt like nulls, but as long as you dont emit them you are okay. I could be wrong about that, but since in this case we are just grabbing an observable im just covering the very odd case its null so that the subsequent it.getValue does not crash

[mtgriego]

i can remove them if you like

[leighdouglas]

🎉