Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1665 & 1662: Project Alerts red dot indicators on overflow menu #2113

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Aug 27, 2024

📲 What

Red dot indicator on each PPO card and in the discovery overflow menu hamburger button and project alerts menu item to indicate that backer has actionable alerts.

🤔 Why

PPO!

🛠 How

  • ppoHasAction field added to the user struct, boolean that we use to determine if the red dot shows in the overflow menu and hamburger button on discovery note that this has not been added to the v1 api user response yet
  • click action added to linear layout group housing the project alert text view and indicator
  • linear layout group gated by ppo feature flag

👀 See

Screenshot_20240826_131308

Screenshot 2024-08-29 at 13 03 41

📋 QA

Since this does not exist on the user struct yet, you can test this by setting the field ppoHasAction to true in the user object response
Should show the red dot indicator on the hamburger menu and should show the red dot on the project alerts menu item.
You also may need to log out and back in to see the indicator on the hamburger button. this is a known issue

Story 📖

MBL-1665: Red error notification dot on discovery overflow hamburger button displays when user has tier 1 project alerts
MBL-1662: Red notification dot in discovery overflow menu project alerts menu item

Leigh Douglas added 6 commits August 27, 2024 14:51
…nd project alert menu item when users has project alerts available
…nd project alert menu item when users has project alerts available
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (794c7f9) to head (83cf5a2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/kickstarter/viewmodels/DiscoveryViewModel.kt 50.00% 0 Missing and 4 partials ⚠️
app/src/main/java/com/kickstarter/models/User.kt 71.42% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2113      +/-   ##
============================================
- Coverage     67.60%   67.59%   -0.01%     
- Complexity     2192     2193       +1     
============================================
  Files           367      367              
  Lines         22597    22609      +12     
  Branches       3248     3253       +5     
============================================
+ Hits          15277    15283       +6     
  Misses         5574     5574              
- Partials       1746     1752       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas self-assigned this Aug 29, 2024
@leighdouglas leighdouglas changed the title Leigh/mbl 1665 red dot overflow MBL-1665 & 1662" Aug 29, 2024
@leighdouglas leighdouglas changed the title MBL-1665 & 1662" MBL-1665 & 1662: Project Alerts red dot indicators on overflow menu Aug 29, 2024
@leighdouglas leighdouglas marked this pull request as ready for review August 29, 2024 17:09
@leighdouglas leighdouglas merged commit 23ea68e into master Sep 3, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1665-red-dot-overflow branch September 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants