-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1665 & 1662: Project Alerts red dot indicators on overflow menu #2113
Conversation
…nd project alert menu item when users has project alerts available
…nd project alert menu item when users has project alerts available
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2113 +/- ##
============================================
- Coverage 67.60% 67.59% -0.01%
- Complexity 2192 2193 +1
============================================
Files 367 367
Lines 22597 22609 +12
Branches 3248 3253 +5
============================================
+ Hits 15277 15283 +6
Misses 5574 5574
- Partials 1746 1752 +6 ☔ View full report in Codecov by Sentry. |
📲 What
Red dot indicator on each PPO card and in the discovery overflow menu hamburger button and project alerts menu item to indicate that backer has actionable alerts.
🤔 Why
PPO!
🛠 How
ppoHasAction
field added to the user struct, boolean that we use to determine if the red dot shows in the overflow menu and hamburger button on discovery note that this has not been added to the v1 api user response yet👀 See
📋 QA
Since this does not exist on the user struct yet, you can test this by setting the field
ppoHasAction
to true in the user object responseShould show the red dot indicator on the hamburger menu and should show the red dot on the project alerts menu item.
You also may need to log out and back in to see the indicator on the hamburger button. this is a known issue
Story 📖
MBL-1665: Red error notification dot on discovery overflow hamburger button displays when user has tier 1 project alerts
MBL-1662: Red notification dot in discovery overflow menu project alerts menu item