Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-818] Remove RX1 from message thread holder view/viewmodel #2111

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Aug 26, 2024

📲 What

Update from RX1 -> Rx2 for the message thread holder view/viewholder

🤔 Why

RX1 -> Bad
RX2 -> still not great but better

🛠 How

🧠

📋 QA

Confirm the messages screen still works as expected

Story 📖

MBL-818

@mtgriego mtgriego self-assigned this Aug 26, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (3edb866) to head (3ae5599).

Files Patch % Lines
...starter/viewmodels/MessageThreadHolderViewModel.kt 81.25% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2111      +/-   ##
============================================
+ Coverage     67.49%   67.51%   +0.02%     
- Complexity     2131     2133       +2     
============================================
  Files           364      364              
  Lines         22181    22186       +5     
  Branches       3118     3116       -2     
============================================
+ Hits          14971    14979       +8     
+ Misses         5571     5568       -3     
  Partials       1639     1639              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtgriego mtgriego merged commit 25bf865 into master Aug 27, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-818 branch August 27, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants