Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1664: Update copy on 3DS validation success and failure snackbars #2100

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

leighdouglas
Copy link
Contributor

📲 What

Updating copy on success and failure snackbars for 3ds in ppo

🤔 Why

Slight delay occurs after user authenticates, so we need to educate them to pull to refresh in order to dismiss the card

📋 QA

Follow these instructions for creating a 3DS pledge: https://app.getguru.com/card/iybnB9pT/Creating-fix-payment-or-3DS-authentication-needed-Pledges-for-mobile-devs

Successful validation should show a snackbar educating the user to pull to refresh
Failing validation should show an authentication failed snackbar

Story 📖

MBL-1664: Update copy on 3DS validation success and failure snackbars

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (ef64663) to head (64c5f73).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2100   +/-   ##
=========================================
  Coverage     67.58%   67.58%           
- Complexity     2127     2128    +1     
=========================================
  Files           363      363           
  Lines         22130    22130           
  Branches       3109     3109           
=========================================
  Hits          14956    14956           
  Misses         5532     5532           
  Partials       1642     1642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas self-assigned this Aug 14, 2024
@leighdouglas leighdouglas marked this pull request as ready for review August 14, 2024 21:43
@leighdouglas leighdouglas merged commit f87255a into master Aug 14, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1664-3ds-copy branch August 14, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants