Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1635: Mock data to real data, and cleanup #2099

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

leighdouglas
Copy link
Contributor

📲 What

Small, mostly cosmetic cleanup for PPO

  • Fix broken backing details page not loading
  • Fix total alerts (0) showing when refreshing PPO screen
  • Disable confirm address button when users address is null

All other cleanup is in separate tickets

🤔 Why

Cleanup cleanup

📋 QA

This will be tricky to test, and will require mock data. You can modify the ppo card factory and hardcode these cards into the graphql transformer function:

Testing backing details page:

  • Add a mock card to the ppo list created in the graphql transformer function
  • In the field for backing details url, you can use your own or this url "/projects/grimacecards/monochrome-muse-playing-cards/backing/details"
  • Tapping on project title area of card should open a webview and load the backing details page
  • Tapping "edit" on a confirm address or survey card should open a webview and load the backing details page

Testing total alerts heading

  • When you have no alerts, visit the PPO page and swipe to refresh. You should not see the total alerts heading appear

Testing edit address button disabled

  • Create a confirm address card with the PPOCardFactory, but leave the address field null. Add this to the ppo screen list in the graphql transformer function
  • Go to the PPO screen, it should not display an address, and the edit button should be disabled and not clickable.

Story 📖

MBL-1635: Mock data to real data, and cleanup](https://kickstarter.atlassian.net/browse/MBL-1635)

@leighdouglas leighdouglas changed the title Leigh/mbl 1635 ppo clean MBL-1635: Mock data to real data, and cleanup Aug 14, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.58%. Comparing base (7d505bf) to head (861d1bf).

Files Patch % Lines
...arter/services/transformers/GraphQLTransformers.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2099      +/-   ##
============================================
- Coverage     67.58%   67.58%   -0.01%     
  Complexity     2128     2128              
============================================
  Files           363      363              
  Lines         22129    22130       +1     
  Branches       3108     3109       +1     
============================================
  Hits          14956    14956              
- Misses         5531     5532       +1     
  Partials       1642     1642              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leighdouglas leighdouglas merged commit ef64663 into master Aug 14, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1635-ppo-clean branch August 14, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants