MBL-1475 Add backing details navigation #2064
Conversation
| @@ -91,6 +91,7 @@ | |||
| <!-- PPO Mock Strings --> | |||
| <string name="project_alerts_fpo">Project Alerts</string> | |||
| <string name="alerts_fpo">Alerts (%1$s)</string> | |||
| <string name="address_confirmed_snackbar_text">Address confirmed! Need to change your address before it locks? Visit your backing details on our website.</string> | |||
| <string name="address_confirmed_snackbar_text_fpo">Address confirmed! Need to change your address before it locks? Visit your backing details on our website.</string> | |||
There was a problem hiding this comment.
I snuck in this tiny string name change unrelated to this ticket because I realized I forgot to add "fpo" to the end of it
| @@ -72,6 +74,8 @@ fun PledgedProjectsOverviewScreen( | |||
| errorSnackBarHostState: SnackbarHostState, | |||
| ppoCards: LazyPagingItems<PPOCardDataMock>, | |||
| totalAlerts: Int = 0, | |||
| onCardClick: () -> Unit, | |||
| onProjectPledgeSummaryClick: (backingDetailsUrl: String) -> Unit, | |||
There was a problem hiding this comment.
Added a new onProjectPledgeSummaryClick lambda for just the pledge summary tap area per the ticket AC. The onCardClick lambda is for the tap area of the entire card, not sure if it's going to end up being used?
There was a problem hiding this comment.
The onCardClick i believe was meant to be used for this part of the feature, but it's fine. i'll just remove it at some point in a subsequent PR
app/src/main/java/com/kickstarter/viewmodels/BackingDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/features/pledgedprojectsoverview/ui/BackingDetailsActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -129,6 +133,7 @@ fun PledgedProjectsOverviewScreen( | |||
| PPOCardView( | |||
| viewType = it.viewType, | |||
| onCardClick = { }, | |||
| onProjectPledgeSummaryClick = { onProjectPledgeSummaryClick(it.backingDetailsUrl) }, | |||
There was a problem hiding this comment.
@leighdouglas Here's where we pass the backingDetailsUrl from the PPO card when user clicks on the tap area.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
============================================
+ Coverage 68.06% 68.07% +0.01%
- Complexity 2113 2114 +1
============================================
Files 355 356 +1
Lines 21652 21671 +19
Branches 3050 3051 +1
============================================
+ Hits 14737 14753 +16
- Misses 5273 5275 +2
- Partials 1642 1643 +1 ☔ View full report in Codecov by Sentry. |
|
|
||
| lifecycleScope.launch { | ||
| repeatOnLifecycle(Lifecycle.State.STARTED) { | ||
| viewModel.url.collect { url -> |
app/src/main/java/com/kickstarter/viewmodels/BackingDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
📲 What
When tapping the project title and thumbnail area of the card, app should open a webview that loads the backing details url
🤔 Why
🛠 How
PPO cards are currently not hooked up to a backend query, so instead I added a
backingDetailsUrlfield to thePPOCardDataMockdata object for now with a test url. Obviously once we hook up real PPO cards this test url should be replaced with the backend-provided url for the backing details.👀 See
Hamburger menu -> Alerts -> tap on pledge summary view:
screen-20240626-163921.mp4
📋 QA
To get PPO cards to show up, on line 15 of the VM, replace
private val ppoCards = MutableStateFlow<PagingData<PPOCardDataMock>>(PagingData.empty())with mock data:
private val ppoCards = MutableStateFlow<PagingData<PPOCardDataMock>>( PagingData.from( listOf( PPOCardDataMock(shippingAddress = "Firsty Lasty\n123 First St Apt #5678\nLos Angeles, CA 90025-1234\nUnited States", viewType = PPOCardViewType.CONFIRM_ADDRESS) ) ) )Tapping the pledge summary view will open up the test url https://www.kickstarter.com/projects/thehoneycouple/the-honey-couples-building-expansion
Story 📖
https://kickstarter.atlassian.net/browse/MBL-1475