Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1541] Update viewmodel to always update if the play button is visible on project videos #2060

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mtgriego
Copy link
Contributor

@mtgriego mtgriego commented Jun 18, 2024

📲 What

Make it so the play button will always be based on the current project

🤔 Why

When entering the project page from discovery we do not have the video as part of the apollo return, so the initial project would not have it so the value would update as expected. On search the video is part of the project because we are still using the api client for that call so the value would not update as expected because its value did not change after initialization.

🛠 How

remove the distinct call until we can switch this to apollo client

📋 QA

Go to a project and confirm its video is working (do this both from discovery and search). Search was where the issue was, not any individual project.

Ticket mentioned the project Misty Valley on production if you want to test that directly.

Story 📖

MBL-1541

@mtgriego mtgriego self-assigned this Jun 18, 2024
@mtgriego mtgriego marked this pull request as ready for review June 18, 2024 21:14
Arkariang
Arkariang previously approved these changes Jun 18, 2024
@Arkariang Arkariang self-requested a review June 18, 2024 21:35
@mtgriego mtgriego merged commit 2342c96 into master Jun 20, 2024
3 checks passed
@mtgriego mtgriego deleted the mgriego/MBL-1541 branch June 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants