-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MBL-1472: Create PPO screen activity, ui, and viewmodel #2056
MBL-1472: Create PPO screen activity, ui, and viewmodel #2056
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2056 +/- ##
============================================
- Coverage 67.63% 67.62% -0.02%
- Complexity 2090 2091 +1
============================================
Files 354 355 +1
Lines 21600 21607 +7
Branches 3044 3044
============================================
+ Hits 14610 14612 +2
- Misses 5352 5358 +6
+ Partials 1638 1637 -1 ☔ View full report in Codecov by Sentry. |
...in/java/com/kickstarter/features/pledgedprojectsoverview/ui/PledgedProjectsOverviewScreen.kt
Outdated
Show resolved
Hide resolved
.../java/com/kickstarter/features/pledgedprojectsoverview/ui/PledgedProjectsOverviewActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 👍
Just one question, do we have a feature flag associated already?
...in/java/com/kickstarter/features/pledgedprojectsoverview/ui/PledgedProjectsOverviewScreen.kt
Outdated
Show resolved
Hide resolved
@Arkariang Yep! The "Project Alerts" menu item in the discovery overflow menu will not appear if the feature flag is turned off, so no way for the screen to open |
|
📲 What
Create the PPO activity, compose ui, and viewmodel scaffold
🛠 How
Since some things might change once we know what the graph payload will look like for the ppo cards, i kept things pretty barebones with mock data and very simple logic for now. I only wrote one compose ui tests for now for the same reason, and will add more later on once the data models and logic are more solidified.
👀 See
📋 QA
Story 📖
MBL-1472: Create PPO screen activity, ui, and viewmodel