Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1472: Create PPO screen activity, ui, and viewmodel #2056

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Jun 10, 2024

📲 What

Create the PPO activity, compose ui, and viewmodel scaffold

🛠 How

  • new screen in compose to hold the list of cards
  • launched from activity
  • created a mockup of what the ppo card model might look like, for testing purposes

Since some things might change once we know what the graph payload will look like for the ppo cards, i kept things pretty barebones with mock data and very simple logic for now. I only wrote one compose ui tests for now for the same reason, and will add more later on once the data models and logic are more solidified.

👀 See

Screenshot 2024-06-10 at 16 45 19

📋 QA

  • When logged in and feature flag on, open the overflow menu on the discovery screen, tap project alerts, and PPO screen should open
  • alerts should say 0, list is empty
  • back button should close screen and return to discovery

Story 📖

MBL-1472: Create PPO screen activity, ui, and viewmodel

@leighdouglas leighdouglas changed the title MBL-1466: Create PPO screen activity, ui, and viewmodel MBL-1472: Create PPO screen activity, ui, and viewmodel Jun 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (6a4f779) to head (3cec86e).

Files Patch % Lines
...view/viewmodel/PledgedProjectsOverviewViewModel.kt 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2056      +/-   ##
============================================
- Coverage     67.63%   67.62%   -0.02%     
- Complexity     2090     2091       +1     
============================================
  Files           354      355       +1     
  Lines         21600    21607       +7     
  Branches       3044     3044              
============================================
+ Hits          14610    14612       +2     
- Misses         5352     5358       +6     
+ Partials       1638     1637       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Arkariang
Arkariang previously approved these changes Jun 10, 2024
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 👍
Just one question, do we have a feature flag associated already?

@leighdouglas
Copy link
Contributor Author

leighdouglas commented Jun 11, 2024

Nice job! 👍 Just one question, do we have a feature flag associated already?

@Arkariang Yep! The "Project Alerts" menu item in the discovery overflow menu will not appear if the feature flag is turned off, so no way for the screen to open

@leighdouglas
Copy link
Contributor Author

  • Swapped old colors for new colors
  • Cleaned up isDarkModeEnabled in activity
  • Swapped in the LazyPagingItems in anticipation of using pager3
  • Added state flows for total alert count and ppo card list

Leigh Douglas added 2 commits June 11, 2024 14:22
@ycheng-kickstarter ycheng-kickstarter merged commit 9cccf09 into master Jun 11, 2024
3 checks passed
@ycheng-kickstarter ycheng-kickstarter deleted the leigh/mbl-1466-confirm-address-mutation branch June 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants