Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1466: Create graphQL confirm address mutation #2053

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

leighdouglas
Copy link
Contributor

📲 What

Adding support for the mutation we will be using to confirm addresses, createOrUpdateBackingAddress

🤔 Why

Needed to confirm backers shipping address for a pledge

🛠 How

Followed best practices for adding a new graphql mutation

👀 See

no user facing changes

📋 QA

Not implemented yet, would have to test call with mock data

Story 📖

MBL-1466: Create graphQL confirm address mutation

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (28f9b43) to head (1c367bd).

Files Patch % Lines
...arter/services/transformers/GraphQLTransformers.kt 0.00% 6 Missing ⚠️
...ices/mutations/CreateOrUpdateBackingAddressData.kt 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2053      +/-   ##
============================================
- Coverage     67.77%   67.74%   -0.03%     
- Complexity     2098     2099       +1     
============================================
  Files           353      354       +1     
  Lines         21587    21598      +11     
  Branches       3050     3050              
============================================
+ Hits          14631    14632       +1     
- Misses         5310     5321      +11     
+ Partials       1646     1645       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas self-assigned this Jun 5, 2024
@leighdouglas leighdouglas marked this pull request as ready for review June 5, 2024 17:16
@leighdouglas leighdouglas merged commit 1a9059c into master Jun 6, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1466-confirm-address-mutation branch June 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants