MBL-1522: Blurry images on Campaign tab #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkariang
commented
May 28, 2024
| @@ -35,19 +42,43 @@ class ImageWithCaptionView @JvmOverloads constructor( | |||
| fun setImage(src: String) { | |||
| if (src.isEmpty() || src.isBlank()) { | |||
| binding.imageView.setImageDrawable(null) | |||
| binding.imageViewPlaceholder.setImageDrawable(null) | |||
| binding.composeViewImage.visibility = GONE | |||
There was a problem hiding this comment.
Avoids recycling cell issues
Arkariang
commented
May 28, 2024
| <androidx.appcompat.widget.AppCompatImageView | ||
| android:id="@+id/image_view_placeholder" |
There was a problem hiding this comment.
The placeholder was the target of zoomIn images, no longer available.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
============================================
- Coverage 67.80% 67.80% -0.01%
+ Complexity 2097 2096 -1
============================================
Files 353 353
Lines 21570 21570
Branches 3044 3044
============================================
- Hits 14626 14625 -1
Misses 5304 5304
- Partials 1640 1641 +1 ☔ View full report in Codecov by Sentry. |
mtgriego
approved these changes
May 28, 2024
Arkariang
added a commit
that referenced
this pull request
Jun 3, 2024
(cherry picked from commit 8c0a861)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
A description of the change.
🤔 Why
So far: Campaign description comes from the HTML parser, we have reduce capabilities to deal or identify the content provided. After some changes made on the infra side we started having issues with images and gifs, Glide migration avoided crashes and gifs not loading but came with a problem causing low resolution images to be presented.
🛠 How
AppCompatImageViewover acomposeViewto allow coilSubcomposeAsyncImagedeal with the images, plus adding the loading indicator.👀 See
| Before 🐛 | After 🦋 |
LoadingIndicator.mp4
| | |
📋 QA
Story 📖
MBL-1522