Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1410: Paging3 sample for GraphQL endpoint. #2045

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented May 27, 2024

πŸ“² What

  • Sample implementation of Pager3 for endpoint getProjectUpdates, using project with many updates frosthaven
  • Available only in Internal tools ❗ not available on external builds

πŸ€” Why

  • Proof of concept for Paging 3 with our architecture and peculiarities.

πŸ›  How

πŸ‘€ See

Pager3.mp4

| | |

πŸ“‹ QA

  • Open internal tools -> Playground -> new activity. If you wanna see updates of other project change the slug on com/kickstarter/ui/activities/PaginationViewModel.kt:77 val project = Project.builder().slug("frosthaven").build()

Story πŸ“–

MBL-1410

@Arkariang Arkariang changed the title MBL-1420: Paging3 sample for GraphQL endpoint. MBL-1410: Paging3 sample for GraphQL endpoint. May 27, 2024
@ycheng-kickstarter
Copy link
Contributor

LGTM. Spike explains things well too. Thanks Isa!

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 67.78%. Comparing base (a913189) to head (686572b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2045   +/-   ##
=========================================
  Coverage     67.77%   67.78%           
- Complexity     2098     2099    +1     
=========================================
  Files           353      353           
  Lines         21587    21587           
  Branches       3050     3050           
=========================================
+ Hits          14631    14632    +1     
  Misses         5310     5310           
+ Partials       1646     1645    -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Arkariang Arkariang merged commit df64aec into master Jun 3, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1420-apolloPaginate branch June 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants