Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rance 2 Hint Disk #33

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Add support for Rance 2 Hint Disk #33

merged 5 commits into from
Jan 4, 2025

Conversation

kichikuou
Copy link
Owner

@kichikuou kichikuou commented Jan 3, 2025

The NACT_Sys1 changes were contributed by @RottenBlock.

To get this to work, you need to put the followings in the current directory:

  • all the .DAT files for Rance 2,
  • GDISK.DAT/GCG.DAT from the hint disk, and
  • AG00.DAT from the hint disk renamed to GG00.DAT

And run system3 with the game id rance2_hint.

Remaining issue:

  • The positions of message box and menu must be adjusted.

AG00.DAT on the hint disk must be renamed to GG00.DAT to avoid conflicts
with AG00.DAT of the main game. This is the setup used in the Ryu1's
porting kit (http://www.ryu1.jp/alice/r2port.html).
@kichikuou
Copy link
Owner Author

I'm only testing it on the Japanese version.

@RottenBlock Since I've made system3 read GDISK.DAT and GG00.DAT, your test environment may need to be adjusted.

@RottenBlock
Copy link

RottenBlock commented Jan 3, 2025

Ah, my bad, I forgot to include ags.cpp in my zip, so the message and dialog boxes got left out. Here's what I originally put:

case CRC32_RANCE2:
case CRC32_RANCE2_HINT:
SET_TEXT(i, 8, 285, 502, 396, true);
SET_MENU(i, 431, 19, 624, 181, true);
break;

That said, here are some screenshots of the hint disk running in Neko Project for comparison's sake, in case we wanted to get even more accurate:

https://imgur.com/a/0qqIzRV

@kichikuou
Copy link
Owner Author

Great, added it to this PR (I changed the last argument to false to not draw a frame around the menu).

Are there any concerns left, including about the code I added? If not, I will merge this and publish a new release.

@RottenBlock
Copy link

Oh, good thinking about the border. I forgot that was a thing. I tried changing the color to replicate the effect but the palette's cyan isn't the same as the PC-98's. Your solution's superior here, I think.

I don't have any other major concerns, I think you can run with it!

@kichikuou kichikuou merged commit 0e2025a into master Jan 4, 2025
18 checks passed
@kichikuou
Copy link
Owner Author

Released as v1.4.0.

@kichikuou kichikuou deleted the rance2 branch January 9, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants