[Uptime] Remove unnecessary queries !! (elastic#191722)

## Summary We added these clauses 4 years ago in a follow up to elastic/beats#14778 !! Since monitor.timespan is now always present in docs , we don't need these queries !! I found these sometimes to be very slow while investigating slow performance of queries in a trace !! ### Autorefresh interval !! Also updated auto refresh interval to 5 minutes, based on multiple customers feedback, default 1 minute is too aggressive !!
kibanamachine · Sep 4, 2024 · e88499a · e88499a
1 parent 1b2cbf1
commit e88499a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 137 deletions.
diff --git a/x-pack/plugins/observability_solution/uptime/common/constants/client_defaults.ts b/x-pack/plugins/observability_solution/uptime/common/constants/client_defaults.ts
@@ -12,9 +12,9 @@ export const CLIENT_DEFAULTS = {
   // 15 minutes
   ABSOLUTE_DATE_RANGE_END: 1000 * 60 * 15,
   /**
-   * The application auto refreshes every 60s by default.
+   * The application auto refreshes every 5mins by default.
    */
-  AUTOREFRESH_INTERVAL: 60 * 1000,
+  AUTOREFRESH_INTERVAL: 5 * 60 * 1000,
   /**
    * The application's autorefresh feature is enabled.
    */

diff --git a/...ity_solution/uptime/public/legacy_uptime/hooks/__snapshots__/use_url_params.test.tsx.snap b/...ity_solution/uptime/public/legacy_uptime/hooks/__snapshots__/use_url_params.test.tsx.snap
diff --git a/...c/legacy_uptime/lib/helper/url_params/__snapshots__/get_supported_url_params.test.ts.snap b/...c/legacy_uptime/lib/helper/url_params/__snapshots__/get_supported_url_params.test.ts.snap
diff --git a/...ervability_solution/uptime/server/legacy_uptime/lib/requests/search/query_context.test.ts b/...ervability_solution/uptime/server/legacy_uptime/lib/requests/search/query_context.test.ts
diff --git a/...s/observability_solution/uptime/server/legacy_uptime/lib/requests/search/query_context.ts b/...s/observability_solution/uptime/server/legacy_uptime/lib/requests/search/query_context.ts
@@ -21,7 +21,6 @@ export class QueryContext {
   filterClause: any | null;
   size: number;
   statusFilter?: string;
-  hasTimespanCache?: boolean;
   query?: string;
 
   constructor(
@@ -48,13 +47,6 @@ export class QueryContext {
     return this.callES.search(params, operationName);
   }
 
-  async count(params: any): Promise<any> {
-    const {
-      result: { body },
-    } = await this.callES.count(params);
-    return body;
-  }
-
   async dateAndCustomFilters(): Promise<ESFilter[]> {
     const clauses = [await this.dateRangeFilter()];
     if (this.filterClause) {
@@ -68,10 +60,6 @@ export class QueryContext {
       range: { '@timestamp': { gte: this.dateRangeStart, lte: this.dateRangeEnd } },
     };
 
-    if (!(await this.hasTimespan())) {
-      return timestampClause;
-    }
-
     return {
       bool: {
         filter: [
@@ -128,28 +116,6 @@ export class QueryContext {
     };
   }
 
-  async hasTimespan(): Promise<boolean> {
-    if (this.hasTimespanCache) {
-      return this.hasTimespanCache;
-    }
-
-    this.hasTimespanCache =
-      (
-        await this.count({
-          body: {
-            query: {
-              bool: {
-                filter: [this.timespanClause()],
-              },
-            },
-          },
-          terminate_after: 1,
-        })
-      ).count > 0;
-
-    return this.hasTimespanCache;
-  }
-
   clone(): QueryContext {
     return new QueryContext(
       this.callES,