[ML] Fix filter for boolean fields filtering for numbers in Field sta…

…tistics/Data Visualizer (elastic#174050) ## Summary This PR fixes elastic#173734 where the clicking to filter a boolean value is searching as numeric representation instead of the true boolean values. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine · Jan 3, 2024 · e1601be · e1601be
1 parent 9dc9d8f
commit e1601be
Show file tree

Hide file tree

Showing 2 changed files with 79 additions and 81 deletions.
diff --git a/x-pack/plugins/data_visualizer/common/types/field_request_config.ts b/x-pack/plugins/data_visualizer/common/types/field_request_config.ts
@@ -65,7 +65,12 @@ export interface FieldVisStats {
   max?: number;
   median?: number;
   min?: number;
-  topValues?: Array<{ key: number | string; doc_count: number; percent: number }>;
+  topValues?: Array<{
+    key: number | string;
+    doc_count: number;
+    percent: number;
+    key_as_string?: string;
+  }>;
   examples?: Array<string | GeoPointExample | object>;
   timeRangeEarliest?: number;
   timeRangeLatest?: number;

diff --git a/...ck/plugins/data_visualizer/public/application/common/components/top_values/top_values.tsx b/...ck/plugins/data_visualizer/public/application/common/components/top_values/top_values.tsx
@@ -114,87 +114,80 @@ export const TopValues: FC<Props> = ({ stats, fieldFormat, barColor, compressed,
         className={classNames('fieldDataTopValuesContainer', 'dvTopValues__wrapper')}
       >
         {Array.isArray(topValues)
-          ? topValues.map((value) => (
-              <EuiFlexGroup gutterSize="xs" alignItems="center" key={value.key}>
-                <EuiFlexItem data-test-subj="dataVisualizerFieldDataTopValueBar">
-                  <EuiProgress
-                    value={value.percent}
-                    max={1}
-                    color={barColor}
-                    size="xs"
-                    label={kibanaFieldFormat(value.key, fieldFormat)}
-                    className={classNames('eui-textTruncate', 'topValuesValueLabelContainer')}
-                    valueText={`${value.doc_count}${
-                      totalDocuments !== undefined
-                        ? ` (${getPercentLabel(value.percent * 100)})`
-                        : ''
-                    }`}
-                  />
-                </EuiFlexItem>
-                {fieldName !== undefined && value.key !== undefined && onAddFilter !== undefined ? (
-                  <div
-                    css={css`
-                      width: 48px;
-                    `}
-                  >
-                    <EuiButtonIcon
-                      iconSize="s"
-                      iconType="plusInCircle"
-                      onClick={() =>
-                        onAddFilter(
-                          fieldName,
-                          typeof value.key === 'number' ? value.key.toString() : value.key,
-                          '+'
-                        )
-                      }
-                      aria-label={i18n.translate(
-                        'xpack.dataVisualizer.dataGrid.field.addFilterAriaLabel',
-                        {
-                          defaultMessage: 'Filter for {fieldName}: "{value}"',
-                          values: { fieldName, value: value.key },
-                        }
-                      )}
-                      data-test-subj={`dvFieldDataTopValuesAddFilterButton-${value.key}-${value.key}`}
-                      style={{
-                        minHeight: 'auto',
-                        minWidth: 'auto',
-                        paddingRight: 2,
-                        paddingLeft: 2,
-                        paddingTop: 0,
-                        paddingBottom: 0,
-                      }}
-                    />
-                    <EuiButtonIcon
-                      iconSize="s"
-                      iconType="minusInCircle"
-                      onClick={() =>
-                        onAddFilter(
-                          fieldName,
-                          typeof value.key === 'number' ? value.key.toString() : value.key,
-                          '-'
-                        )
-                      }
-                      aria-label={i18n.translate(
-                        'xpack.dataVisualizer.dataGrid.field.removeFilterAriaLabel',
-                        {
-                          defaultMessage: 'Filter out {fieldName}: "{value}"',
-                          values: { fieldName, value: value.key },
-                        }
-                      )}
-                      data-test-subj={`dvFieldDataTopValuesExcludeFilterButton-${value.key}-${value.key}`}
-                      style={{
-                        minHeight: 'auto',
-                        minWidth: 'auto',
-                        paddingTop: 0,
-                        paddingBottom: 0,
-                        paddingRight: 2,
-                        paddingLeft: 2,
-                      }}
+          ? topValues.map((value) => {
+              const fieldValue = value.key_as_string ?? value.key.toString();
+              return (
+                <EuiFlexGroup gutterSize="xs" alignItems="center" key={fieldValue}>
+                  <EuiFlexItem data-test-subj="dataVisualizerFieldDataTopValueBar">
+                    <EuiProgress
+                      value={value.percent}
+                      max={1}
+                      color={barColor}
+                      size="xs"
+                      label={kibanaFieldFormat(value.key, fieldFormat)}
+                      className={classNames('eui-textTruncate', 'topValuesValueLabelContainer')}
+                      valueText={`${value.doc_count}${
+                        totalDocuments !== undefined
+                          ? ` (${getPercentLabel(value.percent * 100)})`
+                          : ''
+                      }`}
                     />
-                  </div>
-                ) : null}
-              </EuiFlexGroup>
-            ))
+                  </EuiFlexItem>
+                  {fieldName !== undefined &&
+                  fieldValue !== undefined &&
+                  onAddFilter !== undefined ? (
+                    <div
+                      css={css`
+                        width: 48px;
+                      `}
+                    >
+                      <EuiButtonIcon
+                        iconSize="s"
+                        iconType="plusInCircle"
+                        onClick={() => onAddFilter(fieldName, fieldValue, '+')}
+                        aria-label={i18n.translate(
+                          'xpack.dataVisualizer.dataGrid.field.addFilterAriaLabel',
+                          {
+                            defaultMessage: 'Filter for {fieldName}: "{value}"',
+                            values: { fieldName, value: fieldValue },
+                          }
+                        )}
+                        data-test-subj={`dvFieldDataTopValuesAddFilterButton-${fieldName}-${fieldValue}`}
+                        style={{
+                          minHeight: 'auto',
+                          minWidth: 'auto',
+                          paddingRight: 2,
+                          paddingLeft: 2,
+                          paddingTop: 0,
+                          paddingBottom: 0,
+                        }}
+                      />
+                      <EuiButtonIcon
+                        iconSize="s"
+                        iconType="minusInCircle"
+                        onClick={() => onAddFilter(fieldName, fieldValue, '-')}
+                        aria-label={i18n.translate(
+                          'xpack.dataVisualizer.dataGrid.field.removeFilterAriaLabel',
+                          {
+                            defaultMessage: 'Filter out {fieldName}: "{value}"',
+                            values: { fieldName, value: fieldValue },
+                          }
+                        )}
+                        data-test-subj={`dvFieldDataTopValuesExcludeFilterButton-${fieldName}-${fieldValue}`}
+                        style={{
+                          minHeight: 'auto',
+                          minWidth: 'auto',
+                          paddingTop: 0,
+                          paddingBottom: 0,
+                          paddingRight: 2,
+                          paddingLeft: 2,
+                        }}
+                      />
+                    </div>
+                  ) : null}
+                </EuiFlexGroup>
+              );
+            })
           : null}
         {topValuesOtherCount > 0 ? (
           <EuiFlexGroup gutterSize="xs" alignItems="center" key="other">