[8.11] [Dashboard Navigation] Fix reference extract method (elastic#1…

…71360) (elastic#171561) # Backport This will backport the following commits from `main` to `8.11`: - [[Dashboard Navigation] Fix reference extract method (elastic#171360)](elastic#171360)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Hannah Mudge <[email protected]>
kibanamachine · Nov 20, 2023 · dc03884 · dc03884
1 parent dbf0760
commit dc03884
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 16 deletions.
diff --git a/src/plugins/links/common/persistable_state/references.ts b/src/plugins/links/common/persistable_state/references.ts
@@ -7,6 +7,7 @@
  */
 
 import { Reference } from '@kbn/content-management-utils';
+import { omit } from 'lodash';
 import { DASHBOARD_LINK_TYPE, LinksAttributes } from '../content_management';
 
 export function extractReferences({
@@ -22,23 +23,24 @@ export function extractReferences({
 
   const { links } = attributes;
   const extractedReferences: Reference[] = [];
-  links.forEach((link) => {
+
+  const newLinks = links.map((link) => {
     if (link.type === DASHBOARD_LINK_TYPE && link.destination) {
       const refName = `link_${link.id}_dashboard`;
-      link.destinationRefName = refName;
       extractedReferences.push({
         name: refName,
         type: 'dashboard',
         id: link.destination,
       });
-      delete link.destination;
+      return { ...omit(link, 'destination'), destinationRefName: refName };
     }
+    return link;
   });
 
   return {
     attributes: {
       ...attributes,
-      links,
+      links: newLinks,
     },
     references: references.concat(extractedReferences),
   };

diff --git a/test/functional/apps/dashboard_elements/links/links_create_edit.ts b/test/functional/apps/dashboard_elements/links/links_create_edit.ts
@@ -78,18 +78,33 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await dashboard.clickDiscardChanges();
       });
 
-      it('can create a new by-value links panel', async () => {
-        await dashboardAddPanel.clickEditorMenuButton();
-        await dashboardAddPanel.clickAddNewEmbeddableLink('links');
-        await dashboardLinks.setLayout('horizontal');
-        await createSomeLinks();
-        await dashboardLinks.toggleSaveByReference(false);
-        await dashboardLinks.clickPanelEditorSaveButton();
-        await testSubjects.exists('addObjectToDashboardSuccess');
-
-        expect(await testSubjects.existOrFail('links--component'));
-        expect(await dashboardLinks.getNumberOfLinksInPanel()).to.equal(4);
-        await dashboard.clickDiscardChanges();
+      describe('by-value links panel', async () => {
+        it('can create a new by-value links panel', async () => {
+          await dashboardAddPanel.clickEditorMenuButton();
+          await dashboardAddPanel.clickAddNewEmbeddableLink('links');
+          await dashboardLinks.setLayout('horizontal');
+          await createSomeLinks();
+          await dashboardLinks.toggleSaveByReference(false);
+          await dashboardLinks.clickPanelEditorSaveButton();
+          await testSubjects.exists('addObjectToDashboardSuccess');
+
+          expect(await testSubjects.existOrFail('links--component'));
+          expect(await dashboardLinks.getNumberOfLinksInPanel()).to.equal(4);
+        });
+
+        it('can save by-value links panel to the library', async () => {
+          /** Navigate away to test non-extensible input */
+          await dashboard.gotoDashboardLandingPage();
+          await dashboard.clickUnsavedChangesContinueEditing(DASHBOARD_NAME);
+
+          await dashboard.waitForRenderComplete();
+          await dashboardPanelActions.saveToLibrary('Some more links');
+          await testSubjects.existOrFail('addPanelToLibrarySuccess');
+        });
+
+        after(async () => {
+          await dashboard.clickDiscardChanges();
+        });
       });
     });