forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fleet] Fix security solution tag id (elastic#164582)
Related to elastic#152814 ## Summary Fix for a bug found in elastic#162643 : The security solution tag is actually created with "Security Solution" name and "security-solution-default" id (instead of `SecuritySolution`): ``` { "id": "security-solution-default", "name": "Security Solution", "description": "", "color": "#D36086" } ``` I found that in same cases the tag is duplicated, since[ is not created with an unique id](https://github.com/elastic/kibana/blob/dd0938bea3ebd745a49ac164a7a5f053ba6a138b/x-pack/plugins/security_solution/public/dashboards/containers/use_fetch_security_tags.ts#L44-L51): <img width="3079" alt="Screenshot 2023-08-23 at 15 07 09" src="https://github.com/elastic/kibana/assets/16084106/ef885d8f-2e68-4695-aa14-1adc2e326ab0"> I think it's acceptable to use the "security-solution-default", at least it will create the correct tag name. ### Test For testing I used a package built locally that uses the `Security Solution` tag The steps are the same as described in elastic#162643 - Additionally, check that the `tags` endpoint in the Tags page has name and id as described above: <img width="2521" alt="Screenshot 2023-08-23 at 14 55 05" src="https://github.com/elastic/kibana/assets/16084106/48b3ddd0-3d04-4ff6-8a24-946902687b13">
- Loading branch information
Showing
4 changed files
with
10 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+79.2 KB
...est/fleet_api_integration/apis/fixtures/direct_upload_packages/assets_with_tags-0.1.1.zip
Binary file not shown.