Skip to content

Commit

Permalink
[8.x] [Security Solution] Revert security_solution_common package w…
Browse files Browse the repository at this point in the history
…hich is unnecessary (elastic#198294) (elastic#198877)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Revert `security_solution_common` package which
is unnecessary (elastic#198294)](elastic#198294)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:39:32Z","message":"[Security
Solution] Revert `security_solution_common` package which is unnecessary
(elastic#198294)\n\n## Summary\r\n\r\nThis PR reverts
https://github.com/elastic/kibana/pull/189633.\r\n\r\n###
Background\r\n\r\nPR : elastic#189633 had
created a package\r\n`security_solution_common` so that security
components can be easily\r\nused in Discover plugins.\r\n\r\nBut because
of recent direction change, I have decided to revert that\r\nchange
which mainly moved `flyout` code to the\r\n`security_solution_common`
package.\r\n\r\nMost of the changes that you will see will be path
changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n##
TL;DR\r\n\r\n`security_solution_common` is being removed as the reason
it was created\r\ndoes not exists any
more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.17.0"],"number":198294,"url":"https://github.com/elastic/kibana/pull/198294","mergeCommit":{"message":"[Security
Solution] Revert `security_solution_common` package which is unnecessary
(elastic#198294)\n\n## Summary\r\n\r\nThis PR reverts
https://github.com/elastic/kibana/pull/189633.\r\n\r\n###
Background\r\n\r\nPR : elastic#189633 had
created a package\r\n`security_solution_common` so that security
components can be easily\r\nused in Discover plugins.\r\n\r\nBut because
of recent direction change, I have decided to revert that\r\nchange
which mainly moved `flyout` code to the\r\n`security_solution_common`
package.\r\n\r\nMost of the changes that you will see will be path
changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n##
TL;DR\r\n\r\n`security_solution_common` is being removed as the reason
it was created\r\ndoes not exists any
more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198294","number":198294,"mergeCommit":{"message":"[Security
Solution] Revert `security_solution_common` package which is unnecessary
(elastic#198294)\n\n## Summary\r\n\r\nThis PR reverts
https://github.com/elastic/kibana/pull/189633.\r\n\r\n###
Background\r\n\r\nPR : elastic#189633 had
created a package\r\n`security_solution_common` so that security
components can be easily\r\nused in Discover plugins.\r\n\r\nBut because
of recent direction change, I have decided to revert that\r\nchange
which mainly moved `flyout` code to the\r\n`security_solution_common`
package.\r\n\r\nMost of the changes that you will see will be path
changes replacing\r\n`security_solution_common`.\r\n\r\n\r\n##
TL;DR\r\n\r\n`security_solution_common` is being removed as the reason
it was created\r\ndoes not exists any
more.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"641d0e2d477955c60ccfa290ba5c10601c7f453a"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <[email protected]>
  • Loading branch information
PhilippeOberti and logeekal authored Nov 5, 2024
1 parent 9cc1166 commit 97f60e3
Show file tree
Hide file tree
Showing 120 changed files with 143 additions and 544 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,6 @@
"@kbn/security-plugin-types-public": "link:x-pack/packages/security/plugin_types_public",
"@kbn/security-plugin-types-server": "link:x-pack/packages/security/plugin_types_server",
"@kbn/security-role-management-model": "link:x-pack/packages/security/role_management_model",
"@kbn/security-solution-common": "link:x-pack/packages/security-solution/common",
"@kbn/security-solution-distribution-bar": "link:x-pack/packages/security-solution/distribution_bar",
"@kbn/security-solution-ess": "link:x-pack/plugins/security_solution_ess",
"@kbn/security-solution-features": "link:x-pack/packages/security-solution/features",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import React from 'react';
import { getDiscoverCellRenderer } from '@kbn/security-solution-common';
import { RootProfileProvider, SolutionType } from '../../../profiles';
import { ProfileProviderServices } from '../../profile_provider_services';
import { SecurityProfileProviderFactory } from '../types';
Expand All @@ -21,12 +19,6 @@ export const createSecurityRootProfileProvider: SecurityProfileProviderFactory<
profile: {
getCellRenderers: (prev) => (params) => ({
...prev(params),
'host.name': (props) => {
const CellRenderer = getDiscoverCellRenderer({
fieldName: 'host.name',
});
return <CellRenderer {...props} />;
},
}),
},
resolve: (params) => {
Expand Down
1 change: 0 additions & 1 deletion src/plugins/discover/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"@kbn/presentation-containers",
"@kbn/observability-ai-assistant-plugin",
"@kbn/fields-metadata-plugin",
"@kbn/security-solution-common",
"@kbn/logs-data-access-plugin",
"@kbn/core-lifecycle-browser",
"@kbn/discover-contextual-components",
Expand Down
2 changes: 0 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1576,8 +1576,6 @@
"@kbn/security-plugin-types-server/*": ["x-pack/packages/security/plugin_types_server/*"],
"@kbn/security-role-management-model": ["x-pack/packages/security/role_management_model"],
"@kbn/security-role-management-model/*": ["x-pack/packages/security/role_management_model/*"],
"@kbn/security-solution-common": ["x-pack/packages/security-solution/common"],
"@kbn/security-solution-common/*": ["x-pack/packages/security-solution/common/*"],
"@kbn/security-solution-distribution-bar": ["x-pack/packages/security-solution/distribution_bar"],
"@kbn/security-solution-distribution-bar/*": ["x-pack/packages/security-solution/distribution_bar/*"],
"@kbn/security-solution-ess": ["x-pack/plugins/security_solution_ess"],
Expand Down
11 changes: 0 additions & 11 deletions x-pack/packages/security-solution/common/index.ts

This file was deleted.

12 changes: 0 additions & 12 deletions x-pack/packages/security-solution/common/jest.config.js

This file was deleted.

5 changes: 0 additions & 5 deletions x-pack/packages/security-solution/common/kibana.jsonc

This file was deleted.

8 changes: 0 additions & 8 deletions x-pack/packages/security-solution/common/package.json

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions x-pack/packages/security-solution/common/src/flyout/index.tsx

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 97f60e3

Please sign in to comment.