forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added tests for dot notation processors. (elastic#107340)
* Added tests for dot notation processors. * Fixed nits in PR. * Fixed linting issues.
- Loading branch information
1 parent
62cad9b
commit 239c9a6
Showing
3 changed files
with
129 additions
and
1 deletion.
There are no files selected for viewing
122 changes: 122 additions & 0 deletions
122
...s/public/application/components/pipeline_editor/__jest__/processors/dot_expander.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { act } from 'react-dom/test-utils'; | ||
import { setup, SetupResult, getProcessorValue } from './processor.helpers'; | ||
|
||
const DOT_EXPANDER_TYPE = 'dot_expander'; | ||
|
||
describe('Processor: Dot Expander', () => { | ||
let onUpdate: jest.Mock; | ||
let testBed: SetupResult; | ||
|
||
beforeAll(() => { | ||
jest.useFakeTimers(); | ||
}); | ||
|
||
afterAll(() => { | ||
jest.useRealTimers(); | ||
}); | ||
|
||
beforeEach(async () => { | ||
onUpdate = jest.fn(); | ||
|
||
await act(async () => { | ||
testBed = await setup({ | ||
value: { | ||
processors: [], | ||
}, | ||
onFlyoutOpen: jest.fn(), | ||
onUpdate, | ||
}); | ||
}); | ||
|
||
testBed.component.update(); | ||
|
||
// Open flyout to add new processor | ||
testBed.actions.addProcessor(); | ||
// Add type (the other fields are not visible until a type is selected) | ||
await testBed.actions.addProcessorType(DOT_EXPANDER_TYPE); | ||
}); | ||
|
||
test('prevents form submission if required fields are not provided', async () => { | ||
const { | ||
actions: { saveNewProcessor }, | ||
form, | ||
} = testBed; | ||
|
||
// Click submit button with only the type defined | ||
await saveNewProcessor(); | ||
|
||
// Expect form error as "field" is a required parameter | ||
expect(form.getErrorsMessages()).toEqual(['A field value is required.']); | ||
}); | ||
|
||
test('prevents form submission if field does not contain a . for the dot notation', async () => { | ||
const { | ||
actions: { saveNewProcessor }, | ||
form, | ||
component, | ||
} = testBed; | ||
|
||
// Add invalid "field" value (required) | ||
form.setInputValue('fieldNameField.input', 'missingTheDot'); | ||
|
||
// Save the processor with invalid field | ||
await saveNewProcessor(); | ||
|
||
// Move ahead the debounce time which will then execute any validations | ||
await act(async () => { | ||
jest.runAllTimers(); | ||
}); | ||
component.update(); | ||
|
||
// Expect form error as "field" does not contain '.' | ||
expect(form.getErrorsMessages()).toEqual([ | ||
'A field value requires at least one dot character.', | ||
]); | ||
}); | ||
test('saves with default parameter values', async () => { | ||
const { | ||
actions: { saveNewProcessor }, | ||
form, | ||
} = testBed; | ||
|
||
// Add "field" value (required) | ||
form.setInputValue('fieldNameField.input', 'field.with.dot'); | ||
|
||
// Save the field | ||
await saveNewProcessor(); | ||
|
||
const processors = getProcessorValue(onUpdate, DOT_EXPANDER_TYPE); | ||
expect(processors[0][DOT_EXPANDER_TYPE]).toEqual({ | ||
field: 'field.with.dot', | ||
}); | ||
}); | ||
|
||
test('allows optional parameters to be set', async () => { | ||
const { | ||
actions: { saveNewProcessor }, | ||
form, | ||
} = testBed; | ||
|
||
// Add "field" value (required) | ||
form.setInputValue('fieldNameField.input', 'field.notation'); | ||
|
||
// Set optional parameters | ||
form.setInputValue('pathField.input', 'somepath'); | ||
|
||
// Save the field with new changes | ||
await saveNewProcessor(); | ||
|
||
const processors = getProcessorValue(onUpdate, DOT_EXPANDER_TYPE); | ||
expect(processors[0][DOT_EXPANDER_TYPE]).toEqual({ | ||
field: 'field.notation', | ||
path: 'somepath', | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters