Skip to content

Commit

Permalink
[8.12] [Lens] Fixes wrong tooltip (elastic#172929) (elastic#173018)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Lens] Fixes wrong tooltip
(elastic#172929)](elastic#172929)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T07:26:54Z","message":"[Lens]
Fixes wrong tooltip (elastic#172929)\n\n## Summary\r\n\r\nBecause the
perfection is in the details, this PR fixes a minor bug in\r\nthe inline
editing of **dataview** mode charts. The tooltip mentions\r\nES|QL while
it
shouldn't","sha":"08693ff1b73f76ed1ab352147c2e36b22e57fd49","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.12.0","v8.13.0"],"number":172929,"url":"https://github.com/elastic/kibana/pull/172929","mergeCommit":{"message":"[Lens]
Fixes wrong tooltip (elastic#172929)\n\n## Summary\r\n\r\nBecause the
perfection is in the details, this PR fixes a minor bug in\r\nthe inline
editing of **dataview** mode charts. The tooltip mentions\r\nES|QL while
it
shouldn't","sha":"08693ff1b73f76ed1ab352147c2e36b22e57fd49"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172929","number":172929,"mergeCommit":{"message":"[Lens]
Fixes wrong tooltip (elastic#172929)\n\n## Summary\r\n\r\nBecause the
perfection is in the details, this PR fixes a minor bug in\r\nthe inline
editing of **dataview** mode charts. The tooltip mentions\r\nES|QL while
it shouldn't","sha":"08693ff1b73f76ed1ab352147c2e36b22e57fd49"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
  • Loading branch information
kibanamachine and stratoula authored Dec 11, 2023
1 parent 3cd326b commit 0c2c667
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,18 @@ export const FlyoutWrapper = ({
values: { lang: language },
})}
<EuiToolTip
content={i18n.translate('xpack.lens.config.experimentalLabel', {
defaultMessage:
'Technical preview, ES|QL currently offers limited configuration options',
})}
content={
language
? i18n.translate('xpack.lens.config.experimentalLabelTextBased', {
defaultMessage:
'Technical preview, {lang} currently offers limited configuration options',
values: { lang: language },
})
: i18n.translate('xpack.lens.config.experimentalLabelDataview', {
defaultMessage:
'Technical preview, inline editing currently offers limited configuration options',
})
}
>
<EuiBetaBadge
label="Lab"
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -22210,7 +22210,6 @@
"xpack.lens.config.configFlyoutCallout": "ES|QL propose actuellement des options de configuration limitées",
"xpack.lens.config.editLabel": "Modifier la configuration",
"xpack.lens.config.editLinkLabel": "Modifier dans Lens",
"xpack.lens.config.experimentalLabel": "Version d'évaluation technique",
"xpack.lens.configPanel.addLayerButton": "Ajouter un calque",
"xpack.lens.configPanel.experimentalLabel": "Version d'évaluation technique",
"xpack.lens.configPanel.loadFromLibrary": "Charger depuis la bibliothèque",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -22225,7 +22225,6 @@
"xpack.lens.config.configFlyoutCallout": "現在、ES|QLでは、構成オプションは限られています。",
"xpack.lens.config.editLabel": "構成の編集",
"xpack.lens.config.editLinkLabel": "Lensで編集",
"xpack.lens.config.experimentalLabel": "テクニカルプレビュー",
"xpack.lens.configPanel.addLayerButton": "レイヤーを追加",
"xpack.lens.configPanel.experimentalLabel": "テクニカルプレビュー",
"xpack.lens.configPanel.loadFromLibrary": "ライブラリから読み込み",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -22224,7 +22224,6 @@
"xpack.lens.config.configFlyoutCallout": "ES|QL 当前提供的配置选项数量有限",
"xpack.lens.config.editLabel": "编辑配置",
"xpack.lens.config.editLinkLabel": "在 Lens 中编辑",
"xpack.lens.config.experimentalLabel": "技术预览",
"xpack.lens.configPanel.addLayerButton": "添加图层",
"xpack.lens.configPanel.experimentalLabel": "技术预览",
"xpack.lens.configPanel.loadFromLibrary": "从库中加载",
Expand Down

0 comments on commit 0c2c667

Please sign in to comment.