document implementation details of the operator #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaughn
reviewed
Jun 20, 2023
IMPLEMENTATION.adoc
Outdated
|
|
||
| NOTE: If you need to add support for a new version or remove support for an obsolete version, see link:./DEVELOPING.adoc[DEVELOPING.adoc] for those instructions. | ||
|
|
||
| To tell the KO which version of Kiali to install, you set the `spec.version` field in the Kiali CR. If no `spec.version` is defined in the Kiali CR, the default Ansible role that is executed is defined in link:https://github.com/kiali/kiali-operator/blob/v1.69.0/playbooks/default-playbook.yml[default-playbook.yml] (side note: the file, and the field inside it, are technically named incorrectly. This isn't the default _playbook_, instead it is the default _role_. But ignore that.) Today, the default version of the Ansible role that is invoked is called, literally, link:https://github.com/kiali/kiali-operator/tree/v1.69.0/roles/default[default]. This `default` version is the only one that the upstream Kiali project officially supports. |
There was a problem hiding this comment.
Maybe add a line of why the other roles exist if default is the only one needed for upstream.
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Co-authored-by: Jay Shaughnessy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.