Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kiali-server] Update ingress.yaml to fix apiVersion if condition #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diwap
Copy link

@diwap diwap commented Dec 23, 2024

No description provided.

@diwap diwap changed the title Update ingress.yaml to fix apiVersion if condition [kiali-server] Update ingress.yaml to fix apiVersion if condition Dec 23, 2024
@jmazzitelli
Copy link
Contributor

Please provide a github issue following the community contribution guidelines:

https://github.com/kiali/kiali/blob/master/CONTRIBUTING.md#making-a-change

Explain the bug you think you found and how you think it should be corrected. The Kiali maintainers can then have a dialogue with you before you spend time on code fixes that may or may not be needed.

Also note there is more than just the helm charts - bug fixes likely also need to be fixed in the operator (unless the operator also doesn't have the same bug - this is one reason we ask that community members create an issue so we can have a discussion about the issue prior to PRs being submitted).

@jmazzitelli
Copy link
Contributor

jmazzitelli commented Dec 23, 2024

Note, in the github issue you will create, I will ask about this #95 (that /Ingress was ADDED in a previous release due to the reasons mentioned in that issue). So in your github issue, please address that PR #95 and why you think it needs to be reverted.

Copy link
Contributor

@jmazzitelli jmazzitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This partially reverts PR #95 (it changes one of the if-conditions but not the other one).

Do not merge until we have grounds for reverting PR #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants