fix _pointer_ in casts

khwilson · Sep 24, 2024 · ac05e70 · ac05e70
1 parent 57e655c
commit ac05e70
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/cpp/src/arrow/compute/kernels/aggregate_basic.cc b/cpp/src/arrow/compute/kernels/aggregate_basic.cc
@@ -367,11 +367,11 @@ struct ProductImpl : public ScalarAggregator {
   Status Finalize(KernelContext*, Datum* out) override {
     std::shared_ptr<DataType> out_type_;
     if (out_type->id() == Type::DECIMAL128) {
-      auto cast_type = checked_cast<Decimal128Type>(out_type);
+      auto cast_type = checked_pointer_cast<Decimal128Type>(this->out_type);
       ARROW_ASSIGN_OR_RAISE(out_type_, Decimal128Type::Make(Decimal128Type::kMaxPrecision,
                                                             cast_type->scale()));
     } else if (out_type->id() == Type::DECIMAL256) {
-      auto cast_type = checked_cast<Decimal256Type>(out_type);
+      auto cast_type = checked_pointer_cast<Decimal256Type>(this->out_type);
       ARROW_ASSIGN_OR_RAISE(out_type_, Decimal256Type::Make(Decimal256Type::kMaxPrecision,
                                                             cast_type->scale()));
     } else {

diff --git a/cpp/src/arrow/compute/kernels/aggregate_basic.inc.cc b/cpp/src/arrow/compute/kernels/aggregate_basic.inc.cc
@@ -94,11 +94,11 @@ struct SumImpl : public ScalarAggregator {
   Status Finalize(KernelContext*, Datum* out) override {
     std::shared_ptr<DataType> out_type_;
     if (out_type->id() == Type::DECIMAL128) {
-      auto cast_type = checked_cast<Decimal128Type>(out_type);
+      auto cast_type = checked_pointer_cast<Decimal128Type>(this->out_type);
       ARROW_ASSIGN_OR_RAISE(out_type_, Decimal128Type::Make(Decimal128Type::kMaxPrecision,
                                                             cast_type->scale()));
     } else if (out_type->id() == Type::DECIMAL256) {
-      auto cast_type = checked_cast<Decimal256Type>(out_type);
+      auto cast_type = checked_pointer_cast<Decimal256Type>(this->out_type);
       ARROW_ASSIGN_OR_RAISE(out_type_, Decimal256Type::Make(Decimal256Type::kMaxPrecision,
                                                             cast_type->scale()));
     } else {
@@ -233,7 +233,7 @@ struct MeanImpl<ArrowType, SimdLevel, enable_if_decimal<ArrowType>>
   template <typename T = ArrowType>
   Status FinalizeImpl(Datum* out) {
     std::shared_ptr<DataType> out_type_;
-    auto decimal_type = checked_cast<DecimalType>(this->out_type);
+    auto decimal_type = checked_pointer_cast<DecimalType>(this->out_type);
     if (decimal_type->id() == Type::DECIMAL128) {
       ARROW_ASSIGN_OR_RAISE(out_type_, Decimal128Type::Make(Decimal128Type::kMaxPrecision,
                                                             decimal_type->scale()));