Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share note with other apps function #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diegoalvis
Copy link

No description provided.

@diegoalvis
Copy link
Author

@khuttun is possible that you must upgrade your gradle plugin version, but if you have troubles let me know. Have a nice day!

@khuttun
Copy link
Owner

khuttun commented Oct 24, 2017

Hi @diegoalvis. Thanks for the pull request! The code looks good. Some comments:

  • Could you leave the changes outside app/src out from the commit? They are not directly related to adding the share functionality.

  • Now that I look at the implementation, I started to think that should the share button actually rather be in the Edit note view next to the SAVE button? The notes list looks a bit busy now with the share buttons, and the button actually might go on top of the note text.

@diegoalvis
Copy link
Author

Ok man, @khuttun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants