-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization support 1 #226
Open
hydra
wants to merge
16
commits into
khonsulabs:main
Choose a base branch
from
hydra:add-localization-support-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra
force-pushed
the
add-localization-support-1
branch
from
November 28, 2024 17:41
990101e
to
571b93b
Compare
ecton
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should hopefully fix the layout invalidation issues reported on Discord.
hydra
added a commit
to hydra/cushy
that referenced
this pull request
Nov 28, 2024
hydra
added a commit
to hydra/cushy
that referenced
this pull request
Nov 28, 2024
hydra
force-pushed
the
add-localization-support-1
branch
from
November 28, 2024 18:16
dbb42f6
to
15343ac
Compare
Issues: * Labels for checkboxes should change when the `dynamic_locale` is changed.
The labels change dynamically, but sometimes they are clipped/cropped.
Issues: * The updated label is only shown when the local changes.
…numbers for the counter and prevent overflow.
hydra
force-pushed
the
add-localization-support-1
branch
from
December 1, 2024 18:34
d5d8d3e
to
c655883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state: work-in-progress.
TODO:
Initial cut of localization support using Fluent.
See
examples/localized.rs
.Features:
Localized
to allow for multiple translations to be used at the same time. Use-case is a form designer or report viewer where the main application is in one-language, but you want to preview a form or report in a different language. It works in the same way to being able to override the theme for a widget.Screenshots:
In this screenshot, the window uses the default locale, and the first container shows a label using the window's default locale.
The second container shows a label using a specific locale. The third container is using uses a dynamic locale which can be changed using the radio buttons. It has buttons which update a dynamic value which is used as an argument for a translation.
In this screenshot, the language was changed to "Spanish (Spain)" and the "+" button was clicked once. Here we can see the translations were used.
Fluent translation file for 'es-ES' in the screenshots above is as follows:
In this screenshot, we can see what the UI looks like when no translations are provided.
Limitations:
Acknowledgements: