Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

fix: ending portal loop without processing its flags #119

Merged

Conversation

slaesh
Copy link
Contributor

@slaesh slaesh commented Oct 17, 2022

since the yield was AFTER processing the flags (connect/stop)..
AND we were modifying the loop-criteria, the loop could end BEFORE we had processed our flags!

SO, yield before and there is no need to modify the timeout at all :)

@khoih-prog
Copy link
Owner

HI @slaesh

Please clarify and post some MRE to explain what's wrong and the bug this PR fixes, so that anybody can duplicate the issue and know the benefit of the bug fix.

Not enough with just some words.

Thanks,

@khoih-prog khoih-prog merged commit 82f12e1 into khoih-prog:master Oct 25, 2022
@khoih-prog
Copy link
Owner

OK, I'm merging now. Thanks

khoih-prog added a commit that referenced this pull request Oct 25, 2022
### Releases v1.15.1

1. Using random channel for softAP without password. Check [fix: using random CH for non-password use too #118](#118)
2. Fix bug. Check [fix: ending portal loop without processing its flags #119](#119)
3. Add astyle using `allman` style. Restyle the library
@khoih-prog
Copy link
Owner

Hi @slaesh

The new ESPAsync_WiFiManager v1.15.1 has just been released. Your contribution is noted in Contributions and Thanks

Best Regards,


Releases v1.15.1

  1. Using random channel for softAP without password. Check fix: using random CH for non-password use too #118
  2. Fix bug. Check fix: ending portal loop without processing its flags #119
  3. Add astyle using allman style. Restyle the library

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants