Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added __repr__ to make help display commands properly #2

Closed

Conversation

thecaralice
Copy link

@thecaralice thecaralice commented May 12, 2019

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@khazhyk
Copy link
Owner

khazhyk commented May 12, 2019 via email

@thecaralice
Copy link
Author

thecaralice commented May 13, 2019

@khazhyk can merge now

Copy link
Owner

@khazhyk khazhyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into a single commit too

discord/ext/commands/default.py Outdated Show resolved Hide resolved
discord/ext/commands/default.py Outdated Show resolved Hide resolved
docs/ext/commands/commands.rst Outdated Show resolved Hide resolved
@thecaralice
Copy link
Author

Fixed now @khazhyk

@khazhyk khazhyk force-pushed the rfc-param-default branch from 8fc8d08 to 4d183f4 Compare May 19, 2019 23:29
@khazhyk
Copy link
Owner

khazhyk commented May 19, 2019

Rebased into 4d183f40effbabf8a975817873674cd36c5c3cee

@khazhyk khazhyk closed this May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants