-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for conda #459
Support for conda #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
It'll be nice to close this PR soon and merge the necessary changes now that snakebids v0.13.1 is available on bio-conda ecosystem (https://anaconda.org/bioconda/snakebids) |
What would we need to do to get the unit tests passing? Looks like pyright type checking is failing.. I'm not exactly sure why changing how its imported affects this, but if we can sort that out then we can merge in. |
@akhanf This new commit skips type checking |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 94.37% 94.29% -0.09%
==========================================
Files 55 55
Lines 2222 2225 +3
==========================================
+ Hits 2097 2098 +1
- Misses 125 127 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and passing tests, so I will merge this in..
hmm, looks like the tests didn't actually run in the checks (which I thought they did), so they seem to be failing in main now.. |
Proposed changes
This PR adds a conditional import for the
ruamel_yaml
dependency. This change is necessary because the conda package manager installs the package asruamel_yaml
, while pip installs it asruamel
. This discrepancy leads to import errors when working in a conda environment. The conditional import ensures we are agnostic to the installation method, preventing the import error.Bug Fix:
This PR resolves the import error issue that occurs when the
ruamel.yaml
module is installed via conda. By handling both cases, it ensures the code works in both pip and conda environments.Checklist