Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from Alexays:master #59

Merged
merged 7 commits into from
Aug 4, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
group: clang-tidy
khaneliman committed Aug 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4efa1231835f87b55852cdf9e27b96d0cdb3d60c
2 changes: 1 addition & 1 deletion include/group.hpp
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ namespace waybar {
class Group : public AModule {
public:
Group(const std::string &, const std::string &, const Json::Value &, bool);
virtual ~Group() = default;
~Group() override = default;
auto update() -> void override;
operator Gtk::Widget &() override;

4 changes: 2 additions & 2 deletions src/group.cpp
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@

namespace waybar {

const Gtk::RevealerTransitionType getPreferredTransitionType(bool is_vertical) {
Gtk::RevealerTransitionType getPreferredTransitionType(bool is_vertical) {
/* The transition direction of a drawer is not actually determined by the transition type,
* but rather by the order of 'box' and 'revealer_box':
* 'REVEALER_TRANSITION_TYPE_SLIDE_LEFT' and 'REVEALER_TRANSITION_TYPE_SLIDE_RIGHT'
@@ -112,7 +112,7 @@ bool Group::handleToggle(GdkEventButton* const& e) {
if (!click_to_reveal || e->button != 1) {
return false;
}
if (box.get_state_flags() & Gtk::StateFlags::STATE_FLAG_PRELIGHT) {
if ((box.get_state_flags() & Gtk::StateFlags::STATE_FLAG_PRELIGHT) != 0U) {
hide_group();
} else {
show_group();