Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity as an actual class, rather than factory #37

Merged
merged 28 commits into from
Mar 7, 2021
Merged

Quantity as an actual class, rather than factory #37

merged 28 commits into from
Mar 7, 2021

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Mar 7, 2021

Closes #27.

@khaeru khaeru added the enh New feature or request label Mar 7, 2021
@khaeru khaeru self-assigned this Mar 7, 2021
@codecov-io
Copy link

codecov-io commented Mar 7, 2021

Codecov Report

Merging #37 (0a8d284) into master (c79a727) will decrease coverage by 0.13%.
The diff coverage is 98.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #37      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files           36       36              
  Lines         2111     2217     +106     
===========================================
+ Hits          2111     2214     +103     
- Misses           0        3       +3     
Impacted Files Coverage Δ
genno/tests/core/test_sparsedataarray.py 100.00% <ø> (ø)
genno/tests/test_computations.py 100.00% <ø> (ø)
genno/computations.py 98.87% <92.00%> (-1.13%) ⬇️
genno/core/attrseries.py 99.26% <96.96%> (-0.74%) ⬇️
genno/core/quantity.py 100.00% <100.00%> (ø)
genno/core/sparsedataarray.py 100.00% <100.00%> (ø)
genno/testing.py 100.00% <100.00%> (ø)
genno/tests/core/test_computer.py 100.00% <100.00%> (ø)
genno/tests/core/test_describe.py 100.00% <100.00%> (ø)
genno/tests/core/test_quantity.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79a727...0a8d284. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Quantity a full class
2 participants