AbrarNa'im #7
AbrarNa'im #7
Conversation
server/controller/todo-controller.js
Outdated
| @@ -0,0 +1,99 @@ | |||
| const {Todo} = require ('../models') | |||
| const Super = require('../helper/super.js') | |||
There was a problem hiding this comment.
nama class nya jangan Super ya, mungkin InputValidation lebih cocok
|
untuk validasi tanggal tidak bisa menggunakan isAfter karena argsnya jalan ketika server dijalankan, misal server nyala di 17 agustus , di 19 agustus kita masih bisa bikin todo untuk 18 agustus (karena new date nya dibuat saat 17 agustus) |
|
need improvement: pembuatan model user, validasi email format, validasi email unique |
| let dataBody = req.body | ||
| console.log(dataBody, 'benar' ) | ||
| let newData = Super.validasiRegister(dataBody.password) | ||
| let dataUpuser = { |
There was a problem hiding this comment.
penamaan variabel dibenahi ya, misal newUser
server/routes/todo.js
Outdated
| routers.get('/', TodoController.getTodo) | ||
| routers.post('/', TodoController.postTodo) | ||
|
|
||
| routers.use(authorization) |
There was a problem hiding this comment.
ini tidak bisa begini karena authorization butuh params id
|
|
||
| routers.use(authorization) | ||
|
|
||
| routers.get('/:id', TodoController.getTodoById) |
There was a problem hiding this comment.
authorization di selipin aja ke tengah routers yg butuh authorization
|
di navbar yang ga dipake tolong dihapus ya navigasinya |
|
google login masih belum bekerja |
client/index.js
Outdated
| } | ||
| }) | ||
| .done(res=>{ | ||
| console.log(res) |
There was a problem hiding this comment.
karena hanya di console log jadi belom jalan ya google sign in nya
| jikanjs.settings.setBaseURL('https://api.jikan.moe/v2'); // sets the API Base URL | ||
| jikanjs.settings.setBaseURL('https://api.jikan.moe/v2', 2); // sets also the api version | ||
|
|
||
| class AnimeController{ |
There was a problem hiding this comment.
data anime belum dipakai
|
dokumentasi belum update |
|
baiknya ketika delete user dikonfirmasi yakin/nggak mau delete datanya |
No description provided.