Fix Prisma errors not showing when a Prisma migration errors internally #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
force-pushed
the
fix-prisma-migrate
branch
from
5bd6b44 to
88ed9f3
Compare
dcousens
force-pushed
the
fix-prisma-migrate
branch
from
88ed9f3 to
9ad529c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing as part of #9264, an error was found where the Prisma child process hadn't been populated for
new Migrate.This appears to be a result of us not waiting for
migrate.engine.initPromise.This pull request resolves that by waiting for
initPromise, and thus show any errors that may have happened internally to Prisma.