Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity of extend-express-app example #9068

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Reduce complexity of extend-express-app example #9068

merged 2 commits into from
Mar 26, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Mar 26, 2024

When responding to #9067 (reply in thread), I wanted to reference a working example that explained extendExpressApp and extendHttpServer and withRequest.

The example still isn't adding a custom session, but, this should be better than what was there for now.

Copy link

codesandbox-ci bot commented Mar 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64e5ecb:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 3240bd5 into main Mar 26, 2024
43 checks passed
@dcousens dcousens deleted the express-less branch March 26, 2024 05:50
ggpwnkthx added a commit to Esquire-Media/keystone that referenced this pull request Mar 27, 2024
Reduce complexity of `extend-express-app` example (keystonejs#9068)
@dcousens dcousens mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant