Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce relationship error verbosity #9042

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Feb 26, 2024

The scenario where an invalid 3-way relationship is defined, the error presented is quite verbose:

Foo.bar points to Abc.def, Abc.def points to Foo, expected Abc.def to point to Foo.bar

This pull request changes that error to be equivalent to the following, which is aligned with each of the other relationship errors in structure of {context}, but {problem}.

Foo.bar expects Abc.def to be a two way relationship, but Abc.def points to Foo.bazzz

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5becdc7:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit ee1bdac into main Feb 26, 2024
43 checks passed
@dcousens dcousens deleted the resolve-relationship-errors branch February 26, 2024 04:41
@dcousens dcousens mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant