Update auth-and-access-control.md #9039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another little corrections based in my experience using Keystone. Regards!.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90a3301:
|
dcousens
reviewed
Feb 25, 2024
| @@ -203,11 +203,12 @@ type Session = { | |||
| We can now set up **operation** access control to restrict the **create**, **update** and **delete** operations to authenticated users with the `isAdmin` checkbox set: | |||
|
|
|||
| ```ts | |||
| const isAdmin = ({ session }: { session: Session }) => session?.data.isAdmin; | |||
| const isAdmin = ({ session }: { session: Session }) => Boolean(session?.data.isAdmin); | |||
There was a problem hiding this comment.
Suggested change
| const isAdmin = ({ session }: { session: Session }) => Boolean(session?.data.isAdmin); | |
| const isAdmin = ({ session }: { session?: Session }) => Boolean(session?.data.isAdmin); |
dcousens
reviewed
Feb 25, 2024
| @@ -432,11 +433,14 @@ When you need it, you can call `context.sudo()` to create a new context with ele | |||
| For example, we probably want to block all public access to querying users in our system: | |||
|
|
|||
| ```ts | |||
| const isAdmin = ({ session }: { session: Session }) => session?.data.isAdmin; | |||
| const isAdmin = ({ session }: { session: Session }) => Boolean(session?.data.isAdmin); | |||
There was a problem hiding this comment.
Suggested change
| const isAdmin = ({ session }: { session: Session }) => Boolean(session?.data.isAdmin); | |
| const isAdmin = ({ session }: { session?: Session }) => Boolean(session?.data.isAdmin); |
dcousens
reviewed
Feb 25, 2024
| @@ -515,7 +519,7 @@ const isUser = ({ session }: { session: Session }) => | |||
|
|
|||
| // Validate the current user is an Admin | |||
| const isAdmin = ({ session }: { session: Session }) => | |||
There was a problem hiding this comment.
Suggested change
| const isAdmin = ({ session }: { session: Session }) => | |
| const isAdmin = ({ session }: { session?: Session }) => |
|
Oh, I shouldn't have merged this until we added the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another little corrections based in my experience using Keystone. Regards!.