Fix createInitial* and send*MagicAuthLink to throw if the expected type from sessionStrategy.start is not a string
#9018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0776cfe:
|
dcousens
force-pushed
the
maintenance
branch
from
9e96819 to
0776cfe
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates some comments, refines some types and removes some casts in favour of errors in
packages/auth/src/gql/getInitFirstItemSchema.tsandpackages/auth/src/gql/getMagicAuthLinkSchema.ts.The mutations were previously casting
as string, and this isn't guaranteed by the type ofSessionStrategy.Some other changes are bundled including some minor updates to our release script and GitHub CI naming.
Lastly, this pull request adds some additional defaults in
initConfig, which will be removed soon but can help debugging by reducing the number of cases where configuration variables areundefined.