Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Apollo caching of the adminMeta #9003

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Feb 7, 2024

This bug was quite painful, and I somewhat ended up re-writing a tonne of code while debugging this, but I haven't bundled that work for now.

Unfortunately I haven't found the root cause in @apollo/client as of yet, but, it's clear to me that this a problem with caching.

This pull request sets fetchPolicy: 'no-cache' on our adminMeta queries, which resolves the issue for me.

@dcousens dcousens added the 🐛 bug Unresolved bug label Feb 7, 2024
@dcousens dcousens changed the title Temporarily disable Apollo caching of the adminMeta caching Temporarily disable Apollo caching of the adminMeta Feb 7, 2024
Copy link

codesandbox-ci bot commented Feb 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d37d85:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit fe280c5 into main Feb 7, 2024
12 of 13 checks passed
@dcousens dcousens deleted the no-cache branch February 7, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unresolved bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystone app breaks with interal slice call on getGqlNames
1 participant