Restructure ListItemAccessControl
types
#8915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an attempt at DRY, and trying to read these types, I have opted to merge the
CreateListItemAccessControl
,UpdateListItemAccessControl
andDeleteListItemAccessControl
types into theListItemAccessControl
type, as we have for other types inpackages/core/src/types/config/access-control.ts
.This will help in scenarios where you might want to use
ListItemAccessControl
, but for example only needListItemAccessControl<'create' | 'update'>
.I have additionally unpacked the
KeystoneListsAPI
andKeystoneDbAPI
for future work, which were previously inlined into their respective index signature types.