Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of relationship resolution errors #8842

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Sep 28, 2023

This pull request reduces the verbosity of the errors produced by relationship resolution.
Previously, if you had a misconfigured 2 way relationship, you were presented with the following error:

The relationship field at Foo.bar points to Abc.def, Foo.bar points to Abc correctly but points to the bazz field instead of def

This pull request shortens that to:

Abc.def points to Foo.bazzz, but Foo.bar expects a two-way relationship

Additionally, I add tests for these different edge cases.

@dcousens dcousens requested a review from borisno2 September 28, 2023 13:01
@dcousens dcousens self-assigned this Sep 28, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 65f0bc0:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 60357b7 into main Sep 29, 2023
57 checks passed
@dcousens dcousens deleted the resolve-relationship-errors branch September 29, 2023 02:03
@dcousens dcousens mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants