Remove unsafe types from examples/extend-express-app example
#8839
Conversation
| @@ -23,18 +34,8 @@ export default config<TypeInfo>({ | |||
| Keystone schema and return the results as JSON | |||
| */ | |||
| extendExpressApp: (app, commonContext) => { | |||
| app.use('/rest', async (req, res, next) => { | |||
There was a problem hiding this comment.
We don't want to call withRequest for other HTTP requests, except for GET /rest/tasks, thereby we shouldn't use app.use.
| @@ -11,10 +11,7 @@ import type { Context } from '.keystone/types'; | |||
| We're also demonstrating how you can query related data through the schema. | |||
| */ | |||
|
|
|||
| export async function getTasks(req: Request, res: Response) { | |||
| // This was added by the context middleware in ../keystone.ts | |||
| const { context } = req as typeof req & { context: Context }; | |||
There was a problem hiding this comment.
We don't want to encourage as in user code, the preferred approach is to use a Context parameter directly
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5d0199:
|
|
In the future, we might recommend removal of That needs feedback from the community though, and would probably be quite the controversial breaking change. |
This pull request removes the
(req as any).contexttypes from theextend-express-appexample, and instead prefers to pass a refinedContextdirectly to the route functions.This new pattern reduces the number of
req ascasts, while still keeping your root express router definition as minimal as possible.