Fix types for validateInput hook arguments on update operations #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d622b0d:
|
dcousens
force-pushed
the
fix/hook-types
branch
from
1c8d944 to
e26a754
Compare
|
Thanks @acburdine! |
dcousens
approved these changes
Sep 20, 2023
dcousens
reviewed
Sep 20, 2023
| @@ -106,9 +131,14 @@ export const lists: Lists = { | |||
| return resolvedData; | |||
| }, | |||
| }, | |||
| validateInput: ({ context, inputData, addValidationError }) => { | |||
| validateInput: ({ context, operation, inputData, addValidationError }) => { | |||
There was a problem hiding this comment.
My intent is to replace this soon with per operation typed equivalent, equivalent to validate.create, validate.update and validate.delete, or similar. Like we have with resolveInput.
Or at least validateInput.create and validateInput.update for now.
dcousens
reviewed
Sep 20, 2023
dcousens
force-pushed
the
fix/hook-types
branch
from
9cd03d6 to
d622b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like these were updated incorrectly in #8808. Checked the other types and these appeared to be the only incorrect ones.
didn't create an issue/repro case since it seems to be a pretty straightforward bug/typo, though if I need to create an issue/repro let me know and I can do that 😄 I did vet out this change in my project via patch-package.