Fixes session type as any when using .keystone/types Lists as your root type
#8743
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a6a0db:
|
| @@ -194,7 +194,7 @@ export function printGeneratedTypes( | |||
| prismaClientPath = stringify(prismaClientPath).replace(/'/g, `\\'`); | |||
|
|
|||
| for (const [listKey, list] of Object.entries(lists)) { | |||
| const listTypeInfoName = `Lists.${listKey}.TypeInfo`; | |||
| const listTypeInfoName = `Lists.${listKey}.TypeInfo<Session>`; | |||
There was a problem hiding this comment.
@dcousens Unfortunately this change leads to a TSC error in our system where we have 153 models. TSC is unable to do typechecking with this error:
RangeError: Maximum call stack size exceeded
There was a problem hiding this comment.
removing the passed in Session generic solves the above issue:
- ...
- readonly User: Lists.User.TypeInfo<Session>;
- ...
+ ...
+ readonly User: Lists.User.TypeInfo;
+ ...There was a problem hiding this comment.
@mmachatschek interesting, could you tell me anything about the shape of your Session type?
And or maybe how "interconnected" your models are?
There was a problem hiding this comment.
@dcousens the Session type has several fields but no more than 2 levels of data. All the fields of the Session object have string | null or object | null types.
The models itself very interconnected. As there is a lot of business logic I can not share much of the details or screenshots of the schema/models :/
There was a problem hiding this comment.
More observations so far.
If I add the <Session> generics to a subset of the models, the call stack size doesn't exceed. My guess, the amount of models and therefor the amount of type checking needed is just too big
Edit: So the generic on a specific list/model is not the culprit. Its just the amount of models
There was a problem hiding this comment.
@dcousens I found a feasible solution for us (increasing the v8 stack size for type checking):
keystone disables type checking for keystone build so its ok in this case to ignore this error 🤞 with some hope this is better implemented in a future version of typescript
node --stack-size=4000 ./node_modules/typescript/lib/tsc.js
There was a problem hiding this comment.
I will try and produce a reproduction, conceptually if it's only the number of lists and the number of relationships therein, this shouldn't be too difficult to reproduce.
This pull request fixes
sessiontype becominganywhen using.keystone/typesListsas your root type for your lists definition.