Flatten scripts/* and use stderr for errors, add some deprecations #8569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
commented
May 11, 2023
packages/core/src/access.ts
Outdated
| @@ -9,7 +10,7 @@ export function denyAll() { | |||
| return false; | |||
| } | |||
|
|
|||
| export function unfiltered() { | |||
| export function unfiltered<ListTypeInfo extends BaseListTypeInfo>(): MaybePromise<boolean | ListTypeInfo['inputs']['where']> { | |||
There was a problem hiding this comment.
The type ends up inferring as => boolean, which isn't helpful when you want the type to help infer other function types.
dcousens
commented
May 11, 2023
| /** We do this to stop webpack from bundling next inside of next */ | ||
| const next = 'next/dist/build'; | ||
| const build = require(next).default; | ||
| await build(projectAdminPath); |
There was a problem hiding this comment.
I can't reproduce any behaviors related to this
dcousens
commented
May 11, 2023
| }; | ||
|
|
||
| export async function getNextApp(dev: boolean, projectAdminPath: string): Promise<NextApp> { | ||
| /** We do this to stop webpack from bundling next inside of next */ |
dcousens
force-pushed
the
init-changes
branch
5 times, most recently
from
fa7134e to
b6a896c
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dcousens
changed the title
borisno2
reviewed
May 11, 2023
dcousens
force-pushed
the
init-changes
branch
5 times, most recently
from
e2d477f to
2327545
Compare
dcousens
changed the title
Co-authored-by: Josh Calder <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tidy's up a number of internal modules, flattening their directory structures and removing some now deprecated work-arounds.
As part of the moving,
@keystone-6/core/systemexports (createSystem,createExpressServer,initConfigandcreateAdminUIMiddleware) have been deprecated, and should be removed in the next breaking change.This pull request additionally changes a number of
console.logs toconsole.errorto unify errors being printed tostderr.Lastly, this pull request fixes
keystone devexiting whendb.enableLoggingwas an array.