Resolve Next build errors in Next example #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b86c3a4:
|
|
Tested deploy to vercel using this branch directly - https://vercel.com/new/clone?repository-url=https%3A%2F%2Fgithub.com%2Fkeystonejs%2Fkeystone%2Ftree%2Ffix-keystone-next-vercel%2Fexamples%2Fnextjs-keystone and it works with these changes |
dcousens
reviewed
Apr 6, 2023
| @@ -9,7 +9,7 @@ | |||
| "keystone:start": "keystone start", | |||
| "next:dev": "next dev -p 4000", | |||
| "next:build": "next build", | |||
| "build": "keystone build && next build", | |||
| "build": "keystone build --no-ui && next build", | |||
There was a problem hiding this comment.
The ui is not being used by this example
dcousens
reviewed
Apr 6, 2023
| @@ -19,6 +19,7 @@ | |||
| "@keystone-6/fields-document": "^7.0.0", | |||
| "@preconstruct/next": "^4.0.0", | |||
| "@prisma/client": "^4.12.0", | |||
| "graphql": "^16.6.0", | |||
dcousens
reviewed
Apr 6, 2023
| @@ -3,7 +3,7 @@ | |||
| "target": "esnext", | |||
| "lib": ["dom", "dom.iterable", "esnext"], | |||
| "allowJs": false, | |||
| "skipLibCheck": false, | |||
| "skipLibCheck": true, | |||
dcousens
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
nextjs-keystoneexample deployment for Vercel, as it had a number of build issues.