-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code complexity #8301
Reduce code complexity #8301
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scripts/changelog.js
Outdated
@@ -85,7 +85,7 @@ async function fetchData(tag) { | |||
const changes = {}; | |||
for (const commit of revs) { | |||
let { user, pull } = await getInfo({ repo: 'keystonejs/keystone', commit }); | |||
pull = pull || gitCommitDescription(commit).match(/#([0-9]+)/)[1]; | |||
pull = pull || gitCommitDescription(commit).match(/#([0-9]+)/)?.[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but this is a minor fix for the upcoming release notes
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This pull request refactors
getDbAPIFactory
to not use complicated type resolution and casting, but instead rely on the return type. This is an internal change.