Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code complexity #8301

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Reduce code complexity #8301

merged 4 commits into from
Feb 13, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Feb 13, 2023

This pull request refactors getDbAPIFactory to not use complicated type resolution and casting, but instead rely on the return type. This is an internal change.

@dcousens dcousens requested a review from borisno2 February 13, 2023 06:33
@changeset-bot

This comment was marked as resolved.

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 6:41AM (UTC)

@dcousens dcousens self-assigned this Feb 13, 2023
@@ -85,7 +85,7 @@ async function fetchData(tag) {
const changes = {};
for (const commit of revs) {
let { user, pull } = await getInfo({ repo: 'keystonejs/keystone', commit });
pull = pull || gitCommitDescription(commit).match(/#([0-9]+)/)[1];
pull = pull || gitCommitDescription(commit).match(/#([0-9]+)/)?.[1]
Copy link
Member Author

@dcousens dcousens Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but this is a minor fix for the upcoming release notes

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview February 13, 2023 06:41 Inactive
@dcousens dcousens merged commit 20c515b into main Feb 13, 2023
@dcousens dcousens deleted the reduce-getdbapi-complexity branch February 13, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants