-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent inline related item form from submitting the parent form #8123
Conversation
🦋 Changeset detectedLatest commit: 1b6c49c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b6c49c:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
Inline related item creation is currently semi-broken, because the related item form in a drawer is submitting the main form as well. This results either in the main form showing validation errors just after the related item is created, or, if all the fields in the main form were filled correctly, in the main form being submitted automatically without any value in the relation field.
I think the #7594 introduced the regression, when a separate page started being used to create new items, instead of using the drawer component.
Steps to reproduce the problem (using
tests/test-projects/basic
):I've created a test following these steps, which fails in the current
main
branch, and passes with my fix. The fix itself is very simple - stop form submit event propagation in the drawer component.