ui.publicPages should bypass ui.isAccessAllowed and ui.pageMiddleware
#8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f38970f:
|
emmatown
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the previous behaviour was unintentionally misleading; and although #8115 resolved the behaviour as near to what existed before, I don't think this what developers are expecting.
Public pages shouldn't be redirected conditionally in respect to the session, they are public pages.
If they can be conditionally re-directed as a result of
ui.isAccessAllowedor some other behaviour, then they aren't public pages, but conditional pages, and can be handled usingui.pageMiddleware.This pull request resolves that ambiguity as a separate followup to #8115.
This pull request additionally restores a small optimization that we had which prevented
hasInitFirstItemConditionscalling the database for every request if asessionalready exists (and thereby, initialization already completed).