Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fieldPosition to ui.itemView allowing fields to be moved to the sidebar #8075

Merged
merged 14 commits into from
Nov 10, 2022

Conversation

borisno2
Copy link
Member

@borisno2 borisno2 commented Nov 8, 2022

Adds the ability to set a field's fieldPosition in ui.itemView to either form (standard behaviour) or sidebar - places the field under the id field in the sidebar.

@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 5:34AM (UTC)

@changeset-bot

This comment was marked as resolved.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview November 8, 2022 04:25 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 08:57 Inactive
@gautamsi
Copy link
Member

gautamsi commented Nov 9, 2022

good to see a start on UI improvements.

I hope we can see custom actions in sidebar or other places (v5 UI Hooks) soon.

@vercel vercel bot temporarily deployed to Preview November 9, 2022 22:13 Inactive
@borisno2 borisno2 marked this pull request as ready for review November 9, 2022 22:29
@vercel vercel bot temporarily deployed to Preview November 9, 2022 22:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 9, 2022 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:04 Inactive
@dcousens dcousens force-pushed the fields-item-page-sidebar-positioning branch from db96446 to e99307a Compare November 10, 2022 04:08
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:21 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:28 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:34 Inactive
@dcousens dcousens force-pushed the fields-item-page-sidebar-positioning branch from 5754a9d to 95e52e0 Compare November 10, 2022 04:40
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:42 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:47 Inactive
@dcousens dcousens force-pushed the fields-item-page-sidebar-positioning branch from 80155b1 to 0d2a8a7 Compare November 10, 2022 04:50
@vercel vercel bot temporarily deployed to Preview November 10, 2022 04:53 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 05:34 Inactive
@dcousens dcousens merged commit 7543136 into main Nov 10, 2022
@dcousens dcousens deleted the fields-item-page-sidebar-positioning branch November 10, 2022 05:45
@hsjoshi
Copy link

hsjoshi commented Nov 18, 2022

Awesome, Thanks! It would be great if this can be added to ui.createView as well.

@gautamsi
Copy link
Member

@borisno2 is createView also in roadmap for team? maybe I can create a PR for that

@dcousens
Copy link
Member

@gautamsi not exactly, there are some caveats around how to manage expectations when a create modal is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants