Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changes to some config not being updated in live reloads #8038

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

emmatown
Copy link
Member

Fixes #8028

@vercel
Copy link

vercel bot commented Oct 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 11:44PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2022

🦋 Changeset detected

Latest commit: 03d52f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-6/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview October 23, 2022 23:44 Inactive
Comment on lines -32 to -33
pathname === (graphql?.path || '/api/graphql') ||
pathname === '/api/__keystone_api_build'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deletions don't fix anything, they just became unnecessary after #7910 and #7809 respectively

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03d52f1:

Sandbox Source
@keystone-6/sandbox Configuration

@emmatown emmatown marked this pull request as ready for review October 23, 2022 23:52
@emmatown emmatown requested a review from a team October 23, 2022 23:52
@emmatown emmatown merged commit 4542c1f into main Oct 24, 2022
@emmatown emmatown deleted the fix-live-reloading branch October 24, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite reload when session secret is reset
2 participants