Remove connect
, disconnect
for session strategies
#7971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
connect
anddisconnect
from the SessionStrategy interface, and replaces thesession-store-redis
package with an example.We shouldn't have created a package for what can be effectively reproduced with:
And an
redis.connect()
in thedb.onConnect
hook.Unfortunately
db.onConnect
probably should have been calledonStartup[but before HTTP]
.At the moment,
db.onConnect
happens to be sequentially when we connect the Prisma client, but strictly has no relationship to if and when the Prisma client is connected or disconnected.This can lead to DX confusion when you use a
context
directly fromgetContext
.