Remove queryLimits.maxResults, add maximumTake #7963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
changed the title
dcousens
force-pushed
the
no-context-state
branch
from
2dd14fa to
b15143a
Compare
dcousens
force-pushed
the
no-context-state
branch
from
b15143a to
a029ee0
Compare
dcousens
changed the title
dcousens
force-pushed
the
no-context-state
branch
from
1fc1c61 to
4a7bf19
Compare
dcousens
changed the title
dcousens
commented
Oct 10, 2022
| @@ -386,8 +386,6 @@ Options: | |||
|
|
|||
| - `debug` (default: `process.env.NODE_ENV !== 'production'`): If `true`, stacktraces from both Apollo errors and Keystone errors will be included in the errors returned from the GraphQL API. | |||
| These can be filtered out with `apolloConfig.formatError` if you need to process them, but do not want them returned over the GraphQL API. | |||
| - `queryLimits` (default: `undefined`): Allows you to limit the total number of results returned from a query to your GraphQL API. | |||
There was a problem hiding this comment.
This was removed many moons ago
emmatown
reviewed
Oct 10, 2022
emmatown
reviewed
Oct 10, 2022
emmatown
reviewed
Oct 10, 2022
dcousens
force-pushed
the
no-context-state
branch
from
cc4e995 to
36e0ee3
Compare
dcousens
force-pushed
the
no-context-state
branch
from
b928d6c to
9028496
Compare
Co-authored-by: Mitchell Hamilton <[email protected]>
dcousens
force-pushed
the
no-context-state
branch
from
9028496 to
ae1bcc7
Compare
dcousens
force-pushed
the
no-context-state
branch
from
ae1bcc7 to
70bc49f
Compare
emmatown
reviewed
Oct 10, 2022
Co-authored-by: Mitchell Hamilton <[email protected]>
emmatown
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
context.totalResultsandcontext.maxTotalResults.This state was not carried between
.sudo,.exitSudo, or.withSessionmethods, and is not actually useful for anything except some broad/inaccurate statistics. You should not be using these for any form of security or session control.I recommend we remove the feature completely, if developers want to track a session, they can rely on a custom session strategy.
If developers want to track access to items, they can use the access control functions.
This pull request additionally adds
[list].graphql.maximumTake, a list configuration option to enforce the maximumtakevalue infindManyqueries for that list. This functionality is unambiguous and has clear behavioral boundaries.TODO